Accessibility settings page #3613
Conversation
…-main # Conflicts: # src/app/core/auth/auth.service.ts # src/app/info/info-routing-paths.ts # src/app/info/info-routing.module.ts # src/app/info/info.module.ts # src/app/shared/live-region/live-region.service.spec.ts # src/app/shared/live-region/live-region.service.ts # src/app/shared/notifications/notifications-board/notifications-board.component.spec.ts # src/app/shared/notifications/notifications-board/notifications-board.component.ts # src/config/app-config.interface.ts # src/config/default-app-config.ts
AAwouters
force-pushed
the
accessibility-settings-main
branch
from
12fa618 to
3422ec7
Compare
AAwouters
force-pushed
the
accessibility-settings-main
branch
from
3422ec7 to
923d0ff
Compare
…-main # Conflicts: # src/app/accessibility/accessibility-settings.service.spec.ts # src/app/accessibility/accessibility-settings.service.ts # src/app/info/accessibility-settings/accessibility-settings.component.spec.ts # src/app/info/accessibility-settings/accessibility-settings.component.ts # src/app/info/info.module.ts # src/app/shared/live-region/live-region.service.ts # src/app/shared/notifications/notifications-board/notifications-board.component.ts
AAwouters
force-pushed
the
accessibility-settings-main
branch
from
923d0ff to
ff7c9ba
Compare
|
Hi @AAwouters, |
|
Hi @AAwouters. Thank you for this PR. Overall, it looks really good. I tested it locally, and I'm having a problem with the Accessibility Settings form, both as an anonymous user and when I'm logged in. It happens on Firefox and Chrome. When I change the "Hide notifications automatically" setting to off and click "Save accessibility settings" the green "Successfully saved settings..." notification doesn't go away until I click on the 'X'. That isn't a big problem, but once I change that setting then I can never change it back to on. Every time I do the setting returns to off, even though the green "Successfully saved settings" notification appears. However, I am able to change the Notification and Live region timeouts successfully. The green "Successfully saved settings..." notification appears and disappears on its own. Also, clicking on "Reset accessibility settings" works well. And the green "Successfully reset settings" notification goes away after a few seconds. So I think the problem is only with the option to hide notifications automatically. 
|
References
Fixes point 3 of #1191: "Content visually appears and disappears with no ability to adjust timing."
Description
This PR adds the 'Accessibility settings' page where a user can configure accessibility settings. This page can be found either through the 'Accessibility settings' link in the footer, or through the link on the profile page. The settings are stored in a cookie when the user is not authorized and are stored in a metadata field (see backend PR) when the user is authenticated.
Instructions for Reviewers
Access the page through one of the mentioned links, or directly at
/info/accessibility. Currently only two settings are available: notification time-out and live region time-out. Functionality of the notification time-out is the easiest to verify. Set a new value and click the 'Save accessibility settings` button. A notification will appear mentioning whether the changes are saved locally (cookie) or on the user profile (metadata) and this notification will stay as long as configured.Live region time-out can be verified by making the live region visible. (see #3337)
List of changes in this PR:
accessibility-settingscomponent and servicenotifications-boardwill have the user-configured time-out (if set by the user).Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.